Skip to content

fix(docs): remove horizontal shift on sidebar link hover#2212

Merged
lightwalker-eth merged 1 commit into
mainfrom
fix/docs-sidebar-hover-shift
May 27, 2026
Merged

fix(docs): remove horizontal shift on sidebar link hover#2212
lightwalker-eth merged 1 commit into
mainfrom
fix/docs-sidebar-hover-shift

Conversation

@notrab
Copy link
Copy Markdown
Member

@notrab notrab commented May 27, 2026

Lite PR

Tip: Review docs on the ENSNode PR process

Summary

  • Drop the translateX(2px) transform from the sidebar hover rule
CleanShot 2026-05-27 at 18 57 49

Why

Testing

  • Viewed in browser locally, see GIF

Notes for Reviewer (Optional)

  • Anything non-obvious or worth a heads-up.

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

Copilot AI review requested due to automatic review settings May 27, 2026 17:58
@notrab notrab requested a review from a team as a code owner May 27, 2026 17:58
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 27, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 27, 2026 5:59pm
ensnode.io Ready Ready Preview, Comment May 27, 2026 5:59pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 27, 2026 5:59pm
ensrainbow.io Skipped Skipped May 27, 2026 5:59pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 27, 2026

⚠️ No Changeset found

Latest commit: 1db66de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026 •
edited
Loading

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6d46031d-ea9a-48b9-b79b-1b10f8b63bd4

📥 Commits

Reviewing files that changed from the base of the PR and between d42e0e1 and 1db66de.

📒 Files selected for processing (1)
  • docs/ensnode.io/src/styles/starlight.css
💤 Files with no reviewable changes (1)
  • docs/ensnode.io/src/styles/starlight.css
📝 Walkthrough

Walkthrough

This PR removes a CSS transform effect that shifted sidebar items horizontally on hover. The change simplifies the Starlight theme's sidebar interaction by eliminating the translateX(2px) shift while keeping the background color and border radius styling intact.

Changes

Sidebar Hover Styling

Layer / File(s) Summary
Remove horizontal shift from sidebar hover
docs/ensnode.io/src/styles/starlight.css		 The transform: translateX(2px); declaration is removed from the sidebar hover effect, leaving background color and border radius styling intact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • namehash/ensnode#2151: Both PRs touch docs/ensnode.io/src/styles/starlight.css to change Starlight sidebar hover behavior by adjusting transform effects (including removing the translateX(2px)-style horizontal shift).
  • namehash/ensnode#2170: Both PRs modify docs/ensnode.io/src/styles/starlight.css sidebar hover styling (the main PR removes the translateX(2px) hover transform while the retrieved PR changes/extends hover rules for sidebar links/expandables).

Suggested labels

docs

Poem

A sidebar that shifts left and right,
Now settles still without the flight—
No more translateX in the glow,
Just color and curves, a gentle show. 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a horizontal shift effect on sidebar link hover behavior.
Description check ✅ Passed The PR description follows the template structure with all required sections (Summary, Why, Testing, Pre-Review Checklist) completed with relevant details and visual evidence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-sidebar-hover-shift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

Removes the transform: translateX(2px) declaration from the sidebar hover CSS rule so links and expandable summaries no longer shift horizontally when hovered.

  • The single-line deletion affects the combined hover selector covering non-active sidebar links and all <details> summary elements; the background highlight and border-radius are preserved.

Confidence Score: 5/5

Safe to merge — a single CSS property removal with no functional, logic, or security implications.

The change deletes one CSS declaration from a hover rule. The remaining styles (background highlight and border-radius) are untouched, and no other behaviour is affected.

No files require special attention.

Important Files Changed

Filename Overview
docs/ensnode.io/src/styles/starlight.css Removes transform: translateX(2px) from sidebar link/summary hover rule, eliminating the horizontal shift on hover

Reviews (1): Last reviewed commit: "fix(docs): remove horizontal shift on si..." | Re-trigger Greptile

Copilot AI reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the horizontal “nudge” animation on docs sidebar items by dropping the transform: translateX(2px) from the sidebar hover styling in the Starlight theme overrides.

Changes:

  • Remove the hover transform applied to sidebar links/summaries to prevent horizontal shifting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lightwalker-eth
lightwalker-eth approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab So much better now! Thank you 🫡

@lightwalker-eth lightwalker-eth merged commit 8069fc2 into main May 27, 2026
22 checks passed
@lightwalker-eth lightwalker-eth deleted the fix/docs-sidebar-hover-shift branch May 27, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lightwalker-eth lightwalker-eth lightwalker-eth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notrab @lightwalker-eth